Skip to content

lib: fix readdir in recursive mode with a buffer argument #60936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
y-okt wants to merge 4 commits into
base: main
Choose a base branch
from
Open

lib: fix readdir in recursive mode with a buffer argument #60936

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb1084f
lib: fix readdir in recursive mode with a buffer argument
y-okt Dec 2, 2025
d5f0350
test: add a test to verify withFileTypes case
y-okt Dec 8, 2025
923d4f4
test: fix failing tests on CI
y-okt Dec 13, 2025
909880c
test: fix linting to make CI pass
y-okt Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add a test to verify withFileTypes case 
add a test with withFileTypes true

Fixes: #60936
  • Loading branch information
@y-okt
y-okt committed Dec 13, 2025
commit d5f0350c325c68de700e4bec115acc852447ef2f
2 changes: 2 additions & 0 deletions test/parallel/test-fs-readdir-promise-recursive-with-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@ const { join } = require('node:path');

const testDirPath = join(__dirname, '..', '..');
readdir(Buffer.from(testDirPath), { recursive: true }).then(common.mustCall());

readdir(Buffer.from(testDirPath), { recursive: true, withFileTypes: true }).then(common.mustCall());