Skip to content

test: use RegExp.escape to improve test reliability #60803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Nov 23, 2025
Merged

test: use RegExp.escape to improve test reliability #60803

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c295c7
test: use `RegExp.escape` to improve test reliability
aduh95 Nov 21, 2025
7b845b4
fixup! test: use `RegExp.escape` to improve test reliability
aduh95 Nov 21, 2025
496cf72
fixup! test: use `RegExp.escape` to improve test reliability
aduh95 Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! test: use RegExp.escape to improve test reliability
  • Loading branch information
@aduh95
aduh95 committed Nov 22, 2025
commit 496cf724e2179c2a195f9f4bd789efe265d819ad
3 changes: 1 addition & 2 deletions test/parallel/test-util-inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2912,11 +2912,10 @@ assert.strictEqual(
frame.replaceAll('/', '\\'))
).join('\n');
}
const escapedCWD = util.inspect(process.cwd()).slice(1, -1);
util.inspect(err, { colors: true }).split('\n').forEach(common.mustCallAtLeast((line, i) => {
let expected = stack[i].replace(/node_modules\/(@[^/]+\/[^/]+|[^/]+)/gi, (_, m) => {
return `node_modules/\u001b[4m${m}\u001b[24m`;
}).replaceAll(new RegExp(`(\\(?${RegExp.escape(escapedCWD)}(\\\\|/))`, 'gi'), (_, m) => {
}).replaceAll(new RegExp(`(\\(?${RegExp.escape(process.cwd())}(\\\\|/))`, 'gi'), (_, m) => {
return `\x1B[90m${m}\x1B[39m`;
});
if (expected.includes(process.cwd()) && expected.endsWith(')')) {
Expand Down
Loading