Skip to content

test: ensure assertions are reached on HTTP tests #60729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Nov 17, 2025
Merged

test: ensure assertions are reached on HTTP tests #60729

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a67d942
test: ensure assertions are reached on HTTP tests
aduh95 Nov 15, 2025
c70118f
fixup! test: ensure assertions are reached on HTTP tests
aduh95 Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! test: ensure assertions are reached on HTTP tests
  • Loading branch information
@aduh95
aduh95 committed Nov 15, 2025
commit c70118f1a625aea002847a1223d1be6d53f2c4f0
3 changes: 0 additions & 3 deletions test/parallel/test-http-highwatermark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const net = require('net');
const http = require('http');

Expand All @@ -9,8 +8,6 @@ const http = require('http');
// to be paused and res.write would be failed.
// And it should be resumed when outgoingData falls below highWaterMark.

let requestReceived = 0;

const server = http.createServer(common.mustNotCall()).on('listening', () => {
const c = net.createConnection(server.address().port, () => {
c.write('GET / HTTP/1.1\r\n\r\n');
Expand Down
Loading