chore: update logo asset - #60218
Conversation
|
What is the new logo? Can you provide some context? |
|
Hi this update replaces the old Node.js logo assets with the latest
official version from the Node.js / OpenJS Foundation brand kit.
…On Sun, 12 Oct 2025, 11:10 Marco Ippolito, ***@***.***> wrote:
*marco-ippolito* left a comment (nodejs/node#60218)
<#60218 (comment)>
What is the new logo? Can you provide some context?
—
Reply to this email directly, view it on GitHub
<#60218 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BONRN5V5BXVEHY5DTV6ZJST3XHSU3AVCNFSM6AAAAACI54KK42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOJTHE2TIMZWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
marco-ippolito
left a comment
There was a problem hiding this comment.
this change does not look correct, and there is no rationale for changing these images with completely different one
|
Hi @marco-ippolito,
Thank you for your feedback! I’m still learning the contribution process
and want to make sure I follow the guidelines correctly. Could you please
clarify what would be the correct way to update the logos/images? I want to
make the change correctly without replacing them incorrectly.
Thanks for your guidance!
…On Sun, 12 Oct 2025, 11:55 Marco Ippolito, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
this change does not look correct, and there is no rationale for changing
these images with completely different one
—
Reply to this email directly, view it on GitHub
<#60218 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BONRN5QOIDAJCQG2AMIJIUT3XHX7FAVCNFSM6AAAAACI54KK42VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMRXHEYTKNJZGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Using a PNG image with .jpg file extension is a bad idea, it's going to be confusing for both humans and machines
cc: @marco-ippolito , can you PTAL |
|
What problem are you trying to solve with this PR, you still did not provide a rationale, nor addressed comments left by other collaborators |
|
Ref #60213 |
|
These do not look right. As far as I can tell, these images are used in the Windows and macOS installers and given the differences between the old and new versions this PR will probably result in visual artifacts (either truncation/stretching). For macOS you should be able to build the macOS installer with and the Windows installer with |
|
Yes, these images are not correct, as previously mentioned. However, @abdulfarid-dev, rest assured you didn't do anything wrong, we just don't have a 'correct' way to update these "banners" (AFAICT). |
Summary
Replaced the old Node.js logo with the updated version to maintain consistency with the current branding.
Changes
doc/images/logo.pngReason
The previous logo was outdated. This update aligns with the latest Node.js brand assets.
Signed-off-by: Abdul Farid farid995576@gmail.com