Skip to content

http: improve writeEarlyHints by avoiding for-of loop #59958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Oct 6, 2025
Merged

http: improve writeEarlyHints by avoiding for-of loop #59958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
http: improve writeEarlyHints by avoiding for-of loop
  • Loading branch information
@haramj
haramj committed Sep 21, 2025
commit 17e98e7fa9b5852a24761c5490328e8933c43cca
4 changes: 3 additions & 1 deletion lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,9 @@ ServerResponse.prototype.writeEarlyHints = function writeEarlyHints(hints, cb) {

head += 'Link: ' + link + '\r\n';

for (const key of ObjectKeys(hints)) {
const keys = ObjectKeys(hints);
for (let i = 0; i < keys.length; i++) {
const key = keys[i];
if (key !== 'link') {
head += key + ': ' + hints[key] + '\r\n';
}
Expand Down
Loading