Skip to content

Backport refactor src/node.js into internal files #5975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fishrock123 wants to merge 3 commits into from
Closed

Backport refactor src/node.js into internal files #5975

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37ed119
lib,src: refactor src/node.js into internal files
Fishrock123 Mar 15, 2016
d168ab5
lib,src: move src/node.js to lib/internal/node.js
Fishrock123 Mar 15, 2016
84c28ac
lib: rename /node.js to /bootstrap_node.js
Fishrock123 Mar 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lib: rename /node.js to /bootstrap_node.js 
PR-URL: #5103
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@Fishrock123
Fishrock123 committed Mar 31, 2016
commit 84c28accea33b62eff5d192893e3b14fc06c80d9
0 lib/internal/node.js → lib/internal/bootstrap_node.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
'node_target_type%': 'executable',
'node_core_target_name%': 'node',
'library_files': [
'lib/internal/node.js',
'lib/internal/bootstrap_node.js',
'lib/_debug_agent.js',
'lib/_debugger.js',
'lib/assert.js',
Expand Down
8 changes: 5 additions & 3 deletions src/node_javascript.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,17 @@ using v8::String;

Local<String> MainSource(Environment* env) {
return String::NewFromUtf8(
env->isolate(), reinterpret_cast<const char*>(internal_node_native),
NewStringType::kNormal, sizeof(internal_node_native)).ToLocalChecked();
env->isolate(),
reinterpret_cast<const char*>(internal_bootstrap_node_native),
NewStringType::kNormal,
sizeof(internal_bootstrap_node_native)).ToLocalChecked();
}

void DefineJavaScript(Environment* env, Local<Object> target) {
HandleScope scope(env->isolate());

for (auto native : natives) {
if (native.source != internal_node_native) {
if (native.source != internal_bootstrap_node_native) {
Local<String> name = String::NewFromUtf8(env->isolate(), native.name);
Local<String> source =
String::NewFromUtf8(
Expand Down