Skip to content

test_runner: make signal handling configurable #59674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mete0rfish wants to merge 7 commits into
base: main
Choose a base branch
from
+36 −5
Open

test_runner: make signal handling configurable #59674

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
017d30c
test_runner: make harness hook configurable
mete0rfish Aug 29, 2025
b3bdab5
test_runner: change configure parameter name
mete0rfish Aug 29, 2025
f7fba08
test_runner: use strict check for hookSignal option
mete0rfish Aug 29, 2025
46e4fcc
test: rename spawnAndKill method
mete0rfish Aug 29, 2025
ff0d560
test: remove trailing spaces
mete0rfish Aug 29, 2025
3922f41
doc: update run method option about hookSignal
mete0rfish Aug 31, 2025
54a6e25
test_runner: change default behavior of hookSignal option
mete0rfish Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: rename spawnAndKill method
  • Loading branch information
@mete0rfish
mete0rfish committed Sep 1, 2025
commit 46e4fcc783c3ccafe58e44989b217bdf5875f8ef
6 changes: 3 additions & 3 deletions test/parallel/test-runner-exit-code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ async function runAndKill(file) {
assert.strictEqual(code, 1);
}

async function spawnAndKillProgrammatic(childArgs, { code: expectedCode, signal: expectedSignal }) {
async function spawnAndKill(childArgs, { code: expectedCode, signal: expectedSignal }) {
if (common.isWindows) {
common.printSkipMessage('signals are not supported on windows');
return;
Expand Down Expand Up @@ -88,11 +88,11 @@ if (process.argv[2] === 'child') {
runAndKill(fixtures.path('test-runner', 'never_ending_async.js')).then(common.mustCall());

(async () => {
await spawnAndKillProgrammatic(
await spawnAndKill(
[__filename, 'child', 'run-signal-false'],
{ signal: 'SIGINT', code: null },
);
await spawnAndKillProgrammatic(
await spawnAndKill(
[__filename, 'child', 'run-signal-true'],
{ signal: null, code: 0 },
);
Expand Down