Skip to content

Release proposal: v0.12.13 #5967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rvagg wants to merge 7 commits into from
Closed

Release proposal: v0.12.13 #5967

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ff2bed6
win,build: support Visual C++ Build Tools 2015
joaocgreis Mar 9, 2016
154098a
test: bp fix for test-http-get-pipeline-problem.js
mhdawson Sep 22, 2015
a115779
deps: Disable EXPORT and LOW ciphers in openssl
Mar 14, 2016
9c06db7
test: change tls tests not to use LOW cipher
Mar 15, 2016
ab907eb
test: skip cluster-disconnect-race on Windows
gibfahn Mar 9, 2016
2ce2916
deps: upgrade npm in LTS to 2.15.1
othiym23 Mar 30, 2016
45c18cc
2016-03-31 Version 0.12.13 (LTS) Release
rvagg Mar 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: bp fix for test-http-get-pipeline-problem.js 
backport fix for test-http-get-pipeline-problem.js from master
to 0.12.X.  We've been seeing an intermittent failure
in runs for zLinux with SLES 12.  We confirmed that this fix
resolves the issue so would like it in 0.12.X

The original commit does not apply cleanly as the paths were
changed, but the actual change is identical.  The original commit was:

3ba4f71

PR-URL: #3013
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@mhdawson @jasnell
mhdawson authored and jasnell committed Mar 14, 2016
commit 154098a3dc0903ed6a4e46135bc03b85a686fa73
6 changes: 2 additions & 4 deletions test/simple/test-http-get-pipeline-problem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,10 @@ server.listen(common.PORT, function() {
var s = fs.createWriteStream(common.tmpDir + '/' + x + '.jpg');
res.pipe(s);

// TODO there should be a callback to pipe() that will allow
// us to get a callback when the pipe is finished.
res.on('end', function() {
s.on('finish', function() {
console.error('done ' + x);
if (++responses == total) {
s.on('close', checkFiles);
checkFiles();
}
});
}).on('error', function(e) {
Expand Down