Skip to content

src: fix broken fast callback signatures #59600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Renegade334 wants to merge 4 commits into from
Closed

src: fix broken fast callback signatures #59600

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b47d54b
perf_hooks: fix histogram fast call signatures
Renegade334 Jul 9, 2025
5a50174
process: fix hrtime fast call signatures
Renegade334 Jul 13, 2025
7e590e4
wasi: fix WasiFunction fast call signature
Renegade334 Jul 13, 2025
70f57f5
timers: fix binding fast call signatures
Renegade334 Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
timers: fix binding fast call signatures
  • Loading branch information
@Renegade334
Renegade334 committed Aug 23, 2025
commit 70f57f5d8802b30214ceae4033c34486bc741d87
15 changes: 6 additions & 9 deletions src/timers.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,8 @@ void BindingData::SlowScheduleTimer(const FunctionCallbackInfo<Value>& args) {
}
}

void BindingData::FastScheduleTimer(Local<Object> unused,
Local<Object> receiver,
int64_t duration) {
void BindingData::FastScheduleTimer(Local<Object> receiver, int64_t duration) {
TRACK_V8_FAST_API_CALL("timers.scheduleTimer");
ScheduleTimerImpl(FromJSObject<BindingData>(receiver), duration);
}

Expand All @@ -69,9 +68,8 @@ void BindingData::SlowToggleTimerRef(
args[0]->IsTrue());
}

void BindingData::FastToggleTimerRef(Local<Object> unused,
Local<Object> receiver,
bool ref) {
void BindingData::FastToggleTimerRef(Local<Object> receiver, bool ref) {
TRACK_V8_FAST_API_CALL("timers.toggleTimerRef");
ToggleTimerRefImpl(FromJSObject<BindingData>(receiver), ref);
}

Expand All @@ -85,9 +83,8 @@ void BindingData::SlowToggleImmediateRef(
args[0]->IsTrue());
}

void BindingData::FastToggleImmediateRef(Local<Object> unused,
Local<Object> receiver,
bool ref) {
void BindingData::FastToggleImmediateRef(Local<Object> receiver, bool ref) {
TRACK_V8_FAST_API_CALL("timers.toggleImmediateRef");
ToggleImmediateRefImpl(FromJSObject<BindingData>(receiver), ref);
}

Expand Down
11 changes: 3 additions & 8 deletions src/timers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,18 @@ class BindingData : public SnapshotableObject {

static void SlowScheduleTimer(
const v8::FunctionCallbackInfo<v8::Value>& args);
static void FastScheduleTimer(v8::Local<v8::Object> unused,
v8::Local<v8::Object> receiver,
static void FastScheduleTimer(v8::Local<v8::Object> receiver,
int64_t duration);
static void ScheduleTimerImpl(BindingData* data, int64_t duration);

static void SlowToggleTimerRef(
const v8::FunctionCallbackInfo<v8::Value>& args);
static void FastToggleTimerRef(v8::Local<v8::Object> unused,
v8::Local<v8::Object> receiver,
bool ref);
static void FastToggleTimerRef(v8::Local<v8::Object> receiver, bool ref);
static void ToggleTimerRefImpl(BindingData* data, bool ref);

static void SlowToggleImmediateRef(
const v8::FunctionCallbackInfo<v8::Value>& args);
static void FastToggleImmediateRef(v8::Local<v8::Object> unused,
v8::Local<v8::Object> receiver,
bool ref);
static void FastToggleImmediateRef(v8::Local<v8::Object> receiver, bool ref);
static void ToggleImmediateRefImpl(BindingData* data, bool ref);

static void CreatePerIsolateProperties(IsolateData* isolate_data,
Expand Down
28 changes: 28 additions & 0 deletions test/parallel/test-timers-fast-calls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
// Flags: --allow-natives-syntax --expose-internals --no-warnings
'use strict';

const common = require('../common');
const assert = require('assert');

const { internalBinding } = require('internal/test/binding');
const binding = internalBinding('timers');

function testFastCalls() {
binding.scheduleTimer(1);
binding.toggleTimerRef(true);
binding.toggleTimerRef(false);
binding.toggleImmediateRef(true);
binding.toggleImmediateRef(false);
}

eval('%PrepareFunctionForOptimization(testFastCalls)');
testFastCalls();
eval('%OptimizeFunctionOnNextCall(testFastCalls)');
testFastCalls();

if (common.isDebug) {
const { getV8FastApiCallCount } = internalBinding('debug');
assert.strictEqual(getV8FastApiCallCount('timers.scheduleTimer'), 1);
assert.strictEqual(getV8FastApiCallCount('timers.toggleTimerRef'), 2);
assert.strictEqual(getV8FastApiCallCount('timers.toggleImmediateRef'), 2);
}
Loading