Skip to content

[v20.x] backport require(esm) bugfixes and improvements #59504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 9 commits into from
Closed

[v20.x] backport require(esm) bugfixes and improvements #59504

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9b72f5f
module: handle .mjs in .js handler in CommonJS
joyeecheung Oct 31, 2024
a26abb6
src: do not format single string argument for THROW_ERR_*
joyeecheung Feb 18, 2025
914cc71
module: improve error message from asynchronicity in require(esm)
joyeecheung Feb 17, 2025
d52043a
module: handle cached linked async jobs in require(esm)
joyeecheung Mar 4, 2025
feb6167
module: fix incorrect formatting in require(esm) cycle error message
haykam821 Apr 9, 2025
08ff294
module: handle instantiated async module jobs in require(esm)
joyeecheung May 8, 2025
10c4efd
module: clarify cjs global-like error on ModuleJobSync
Ceres6 May 16, 2025
b29b874
module: allow cycles in require() in the CJS handling in ESM loader
joyeecheung Jun 11, 2025
bd6691a
module: throw error when re-runing errored module jobs
joyeecheung Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: do not format single string argument for THROW_ERR_* 
If the macros are used as ERR_*(isolate, message) or
THROW_ERR_*(isolate, message) with a single string argument, do run
formatter on the message, and allow the caller to pass in a message
directly with characters that would otherwise need escaping if used
as format string unconditionally.

PR-URL: #57126
Refs: https://github.com/fisker/prettier-issue-17139
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
  • Loading branch information
@joyeecheung @marco-ippolito
joyeecheung authored and marco-ippolito committed Aug 20, 2025
commit a26abb6ac5bd6b67d2dd8acb278e68dd67987004
12 changes: 11 additions & 1 deletion src/node_errors.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,21 @@ void OOMErrorHandler(const char* location, const v8::OOMDetails& details);
V(ERR_WORKER_INIT_FAILED, Error) \
V(ERR_PROTO_ACCESS, Error)

// If the macros are used as ERR_*(isolate, message) or
// THROW_ERR_*(isolate, message) with a single string argument, do run
// formatter on the message, and allow the caller to pass in a message
// directly with characters that would otherwise need escaping if used
// as format string unconditionally.
#define V(code, type) \
template <typename... Args> \
inline v8::Local<v8::Object> code( \
v8::Isolate* isolate, const char* format, Args&&... args) { \
std::string message = SPrintF(format, std::forward<Args>(args)...); \
std::string message; \
if (sizeof...(Args) == 0) { \
message = format; \
} else { \
message = SPrintF(format, std::forward<Args>(args)...); \
} \
v8::Local<v8::String> js_code = OneByteString(isolate, #code); \
v8::Local<v8::String> js_msg = \
v8::String::NewFromUtf8(isolate, \
Expand Down