-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
sqlite: statement.setReadNullAsUndefined() #59462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jac0bandres
wants to merge
6
commits into
nodejs:main
Choose a base branch
from
jac0bandres:dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+262
−20
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1c3702c
src: add setReadNullAsUndefined() to StatementSync in node_sqlite.cc …
jac0bandres f4a6327
Merge branch 'nodejs:main' into dev
jac0bandres 06e050f
sqlite: add statement.setReadNullAsUndefined, add options.readNullAsU…
jac0bandres 8af485a
sqlite: add statement.setReadNullAsUndefined, add options.readNullAsU…
jac0bandres f248a9e
sqlite: add statement.setReadNullAsUndefined, add options.readNullAsU…
jac0bandres b62aed9
sqlite: add statement.setReadNullAsUndefined, add options.readNullAsU…
jac0bandres File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -275,6 +275,58 @@ | |
| }); | ||
| }); | ||
|
|
||
| suite('StatementSync.prototype.setReadNullAsUndefined', () => { | ||
| test('Null can be read as undefined', (t) => { | ||
| const db = new DatabaseSync(nextDb()); | ||
| t.after(() => { db.close(); }); | ||
| const setup = db.exec(` | ||
| CREATE TABLE data(is_null TEXT DEFAULT NULL) STRICT; | ||
| INSERT INTO data(is_null) VALUES(NULL); | ||
| `) | ||
| t.assert.strictEqual(setup, undefined); | ||
|
|
||
| const query = db.prepare('SELECT is_null FROM DATA'); | ||
| t.assert.deepStrictEqual(query.get(),{ __proto__: null, is_null: null}); | ||
| t.assert.strictEqual(query.setReadNullAsUndefined(true), undefined); | ||
| t.assert.deepStrictEqual(query.get(), { __proto__: null, is_null: undefined}); | ||
| t.assert.strictEqual(query.setReadNullAsUndefined(false), undefined); | ||
| t.assert.deepStrictEqual(query.get(), { __proto__: null, is_null: null}); | ||
| }) | ||
|
|
||
| test('does not affect non-null values', (t) => { | ||
| const db = new DatabaseSync(nextDb()); | ||
| t.after(() => { db.close(); }); | ||
| const setup = db.exec(` | ||
| CREATE TABLE data(is_not_null TEXT) STRICT; | ||
| INSERT INTO data(is_not_null) VALUES('This is not null'); | ||
| `) | ||
| t.assert.strictEqual(setup, undefined); | ||
|
|
||
| const query = db.prepare('SELECT is_not_null FROM DATA'); | ||
| t.assert.deepStrictEqual(query.get(),{ __proto__: null, is_not_null: 'This is not null'}); | ||
| t.assert.strictEqual(query.setReadNullAsUndefined(true), undefined); | ||
| console.log(query.get()) | ||
| t.assert.deepStrictEqual(query.get(), { __proto__: null, is_not_null: 'This is not null'}); | ||
| }) | ||
| test('throws when input is not a boolean', (t) => { | ||
| const db = new DatabaseSync(nextDb()); | ||
| t.after(() => { db.close(); }); | ||
| const setup = db.exec(` | ||
| CREATE TABLE data(is_not_null TEXT) STRICT; | ||
| INSERT INTO data(is_not_null) VALUES('This is not null'); | ||
| `) | ||
| t.assert.strictEqual(setup, undefined); | ||
|
|
||
| const stmt = db.prepare('SELECT is_not_null FROM data'); | ||
| t.assert.throws(() => { | ||
| stmt.setReadNullAsUndefined(); | ||
| }, { | ||
| code: 'ERR_INVALID_ARG_TYPE', | ||
| message: /The "readNullAsUndefined" argument must be a boolean/, | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| suite('StatementSync.prototype.setReadBigInts()', () => { | ||
| test('BigInts support can be toggled', (t) => { | ||
| const db = new DatabaseSync(nextDb()); | ||
|
|
@@ -327,8 +379,7 @@ | |
|
|
||
| test('BigInt is required for reading large integers', (t) => { | ||
| const db = new DatabaseSync(nextDb()); | ||
| t.after(() => { db.close(); }); | ||
| const bad = db.prepare(`SELECT ${Number.MAX_SAFE_INTEGER} + 1`); | ||
| t.after(() => { db.close(); }); const bad = db.prepare(`SELECT ${Number.MAX_SAFE_INTEGER} + 1`); | ||
|
Comment on lines
-415
to
+386
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change looks unrelated. |
||
| t.assert.throws(() => { | ||
| bad.get(); | ||
| }, { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LiviaMedeiros when the value is undefined, should it be included as a key in the returned object?
V8 optimizes creation of the objects with similar shape but I don't know if this applies to objects created via C++ directly, if not, maybe could be worthy/faster just exclude this field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performance-wise, i don't know. On huge amounts of rows and sparse data, i would expect hidden class to be faster at the cost of extra memory consumption; but without benchmarking it's just a guess.
However, this difference is observable in userland, which outweights microoptimizations. I think, explicit
undefinedis better:If we get rows as objects using
SELECT * FROM ..., we should be able to check what*was resolved to.If we use
returnArrays: trueorstatement.setReturnArrays(true)and keep it consistent with objects, omittingundefinedmeans having sparse arrays which are counterintuitive.If there is significant performance benefit from excluding fields, we can consider more explicit
useNullAsEmpty. Or changing this from boolean touseNullAs(enum)whilenode:sqliteis still experimental.