Skip to content

crypto: support ML-DSA KeyObject, sign, and verify #59259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 13 commits into from
Aug 6, 2025
Merged

crypto: support ML-DSA KeyObject, sign, and verify #59259

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
69fc44e
crypto: support ML-DSA KeyObject, sign, and verify
panva Jul 27, 2025
ce580f0
check vectors from ietf-cose-dilithium
panva Jul 29, 2025
d8d1043
fixup crypto.generateKeyPair doc type
panva Jul 29, 2025
24670db
use primordial
panva Jul 29, 2025
aaa2d1d
add benchmarks
panva Jul 29, 2025
bba6de7
use native handle init for JWK public inputs
panva Jul 29, 2025
a3a2f52
cpp implementation of init from seed
panva Jul 29, 2025
4678673
apply feedback (first of many)
panva Jul 29, 2025
e15987f
apply more feedback
panva Jul 29, 2025
7e614d7
fixup unregistered external reference
panva Jul 29, 2025
657b4b2
add benchmark for create*Key
panva Jul 29, 2025
fd954bf
resolve lint
panva Aug 1, 2025
7b10239
lint
panva Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use primordial
  • Loading branch information
@panva
panva committed Jul 29, 2025
commit 24670db5e80e0ce518c64cdb18064b7cdb93fd5f
3 changes: 2 additions & 1 deletion lib/internal/crypto/keys.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

const {
ArrayPrototypeSlice,
ArrayPrototypeUnshift,
ObjectDefineProperties,
ObjectDefineProperty,
ObjectSetPrototypeOf,
Expand Down Expand Up @@ -539,7 +540,7 @@ function encodeLength(length) {
const bytes = [];
let temp = length;
while (temp > 0) {
bytes.unshift(temp & 0xff);
ArrayPrototypeUnshift(bytes, temp & 0xff);
temp >>>= 8;
}

Expand Down