Skip to content

build: introduce ci targets for lint/benchmark #5921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbergstroem wants to merge 2 commits into from
Closed

build: introduce ci targets for lint/benchmark #5921

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d233d5
build: introduce ci targets for lint/benchmark
jbergstroem Mar 27, 2016
ddfc9c8
fix: add bench-ci to .phony
jbergstroem Mar 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: introduce ci targets for lint/benchmark 
Introduce two new targets we will populate with actions
once merged into all branches we need to support through CI.
  • Loading branch information
@jbergstroem
jbergstroem committed Mar 27, 2016
commit 1d233d580128b7a381a71e535e096958d19c784a
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,8 @@ bench-all: bench bench-misc bench-array bench-buffer bench-url bench-events benc

bench: bench-net bench-http bench-fs bench-tls

bench-ci: bench

bench-http-simple:
benchmark/http_simple_bench.sh

Expand Down Expand Up @@ -630,10 +632,12 @@ lint:
"$ git clone https://github.com/nodejs/node.git"
endif

lint-ci: lint

.PHONY: lint cpplint jslint bench clean docopen docclean doc dist distclean \
check uninstall install install-includes install-bin all staticlib \
dynamiclib test test-all test-addons build-addons website-upload pkg \
blog blogclean tar binary release-only bench-http-simple bench-idle \
bench-all bench bench-misc bench-array bench-buffer bench-net \
bench-http bench-fs bench-tls cctest run-ci test-v8 test-v8-intl \
test-v8-benchmarks test-v8-all v8
test-v8-benchmarks test-v8-all v8 lint-ci
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Mar 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove lint at the beginning of this then?

Copy link
Copy Markdown
Member Author

@jbergstroem jbergstroem Mar 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, its still a target?