Skip to content

benchmark: fix sqlite-is-transaction #59170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 24, 2025
Merged

benchmark: fix sqlite-is-transaction #59170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
benchmark: fix sqlite-is-transaction 
The variable deadCodeElimination is declared
but not initialized, making it undefined by default.
When using the &&= operator with an undefined left operand,
the result will always remain undefined regardless of
how many iterations run.

```js
let deadCodeElimination;
deadCodeElimination &&= true
deadCodeElimination // undefined
```
  • Loading branch information
@RafaelGSS
RafaelGSS committed Jul 22, 2025
commit afdb248bd2e5ecba02101888cfd2660843ed0878
2 changes: 1 addition & 1 deletion benchmark/sqlite/sqlite-is-transaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function main(conf) {
}

let i;
let deadCodeElimination;
let deadCodeElimination = true;

bench.start();
for (i = 0; i < conf.n; i += 1)
Expand Down
Loading