Skip to content

test: remove timeout in test-https-proxy-request-handshake-failure #59165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 25, 2025
Merged

test: remove timeout in test-https-proxy-request-handshake-failure #59165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove timeout in test-https-proxy-request-handshake-failure 
The timeout is unnecessary since we are testing for certificate
failure. It can cause flakes on very slow machines where the
request cannot be finished in 1 second.
  • Loading branch information
@joyeecheung
joyeecheung committed Jul 22, 2025
commit d510e5049d86abd198ec5a4dea1df79eea300bbc
1 change: 0 additions & 1 deletion test/client-proxy/test-https-proxy-request-handshake-failure.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ const requestUrl = `https://${serverHost}/test`;
const { code, signal, stderr, stdout } = await runProxiedRequest({
NODE_USE_ENV_PROXY: 1,
REQUEST_URL: requestUrl,
REQUEST_TIMEOUT: 1000,
HTTPS_PROXY: `http://localhost:${proxy.address().port}`,
});

Expand Down
Loading