Skip to content

tools: add support for URLs to PR commits in merge.sh #59162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Jul 24, 2025
Merged

tools: add support for URLs to PR commits in merge.sh #59162

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be77b37
tools: add support for URLs to PR commits in `merge.sh`
aduh95 Jul 22, 2025
3dc1eb3
fixup! tools: add support for URLs to PR commits in `merge.sh`
aduh95 Jul 22, 2025
dab997e
fixup! tools: add support for URLs to PR commits in `merge.sh`
aduh95 Jul 22, 2025
97e62c7
Update tools/actions/merge.sh
aduh95 Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: add support for URLs to PR commits in merge.sh
  • Loading branch information
@aduh95
aduh95 committed Jul 22, 2025
commit be77b37d3fa2157386464e9b3c364f66304fc8e2
29 changes: 25 additions & 4 deletions tools/actions/merge.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,46 @@
# To land a PR with this tool:
# 1. Run `git node land <pr-id-or-url> --fixupAll`
# 2. Copy the hash of the commit at the top of the PR branch.
# 3. Run `tools/actions/merge.sh <pr-id-or-url> <commit-hash>`.
# 3. Run `tools/actions/merge.sh <pr-id-or-url> <commit-hash>` or `tools/actions/merge.sh <url-to-PR-commit>`.

set -xe

pr=$1
commit_head=$2
shift 2 || { echo "Expected two arguments"; exit 1; }

OWNER=nodejs
REPOSITORY=node

if expr "X$pr" : 'Xhttps://github.com/[^/]\{1,\}/[^/]\{1,\}/pull/[0-9]\{1,\}' >/dev/null; then
OWNER="$(echo "$pr" | awk 'BEGIN { FS = "/" } ; { print $4 }')"
REPOSITORY="$(echo "$pr" | awk 'BEGIN { FS = "/" } ; { print $5 }')"
[ -n "$commit_head" ] || commit_head="$(echo "$pr" | awk 'BEGIN { FS = "/" } ; { print $9 }')"
pr="$(echo "$pr" | awk 'BEGIN { FS = "/" } ; { print $7 }')"
elif ! expr "X$pr" : 'X[0-9]\{1,\}' >/dev/null; then
echo "The first argument should be the PR ID or URL"
fi

validation_error=
if ! expr "X$pr" : 'X[0-9]\{1,\}' >/dev/null; then
set +x
echo "Invalid PR ID: $pr"
validation_error=1
fi
if ! expr "X$commit_head" : 'X[a-f0-9]\{40\}' >/dev/null; then
set +x
echo "Invalid PR head: $commit_head"
validation_error=1
fi
[ -z "$validation_error" ] || {
echo 'Usage:'
echo "\t$0 <pr-id-or-url> <commit-hash>"

Check failure on line 39 in tools/actions/merge.sh

View workflow job for this annotation

GitHub Actions / lint-sh 

/home/runner/work/node/node/tools/actions/merge.sh:39:8: echo may not expand escape sequences. Use printf.
echo 'or:'
echo "\t$0 <url-to-PR-commit>"

Check failure on line 41 in tools/actions/merge.sh

View workflow job for this annotation

GitHub Actions / lint-sh 

/home/runner/work/node/node/tools/actions/merge.sh:41:8: echo may not expand escape sequences. Use printf.
echo 'Examples:'
echo "\t$0 12345 aaaaabbbbbcccccdddddeeeeefffff1111122222"

Check failure on line 43 in tools/actions/merge.sh

View workflow job for this annotation

GitHub Actions / lint-sh 

/home/runner/work/node/node/tools/actions/merge.sh:43:8: echo may not expand escape sequences. Use printf.
echo "\t$0 https://github.com/$OWNER/$REPOSITORY/pull/12345 aaaaabbbbbcccccdddddeeeeefffff1111122222"

Check failure on line 44 in tools/actions/merge.sh

View workflow job for this annotation

GitHub Actions / lint-sh 

/home/runner/work/node/node/tools/actions/merge.sh:44:8: echo may not expand escape sequences. Use printf.
echo "\t$0 https://github.com/$OWNER/$REPOSITORY/pull/12345/commit/aaaaabbbbbcccccdddddeeeeefffff1111122222"

Check failure on line 45 in tools/actions/merge.sh

View workflow job for this annotation

GitHub Actions / lint-sh 

/home/runner/work/node/node/tools/actions/merge.sh:45:8: echo may not expand escape sequences. Use printf.
exit 1
}

git log -1 HEAD --pretty='format:%B' | git interpret-trailers --parse --no-divider | \
grep -q -x "^PR-URL: https://github.com/$OWNER/$REPOSITORY/pull/$pr$" || {
echo "Invalid PR-URL trailer"
Expand Down
Loading