Skip to content

dgram: improve get-send-queue-info performance #59054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IlyasShabi wants to merge 6 commits into
base: main
Choose a base branch
from
+123 −3
Open

dgram: improve get-send-queue-info performance #59054

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a28d1ec
dgram: add fast api for get-send-queue-size method
IlyasShabi Jul 13, 2025
5d4dfa2
keep packets unsent to have data in getters
IlyasShabi Jul 14, 2025
2c85454
fix benchmark test
IlyasShabi Jul 14, 2025
b1db93f
add fast api test
IlyasShabi Aug 4, 2025
6471d1c
fix linter
IlyasShabi Aug 4, 2025
49d0d65
src: track fast api call
IlyasShabi Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add fast api test
  • Loading branch information
@IlyasShabi
IlyasShabi committed Nov 2, 2025
commit b1db93fe8cb4913fe4641bda92099ee693f73055
38 changes: 38 additions & 0 deletions test/parallel/test-dgram-fast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// Flags: --expose-internals --no-warnings --allow-natives-syntax --test-udp-no-try-send
'use strict';

const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');

const { internalBinding } = require('internal/test/binding');

function testFastDgram() {
const server = dgram.createSocket('udp4');
const client = dgram.createSocket('udp4');

server.bind(0, common.mustCall(() => {
client.connect(server.address().port, common.mustCall(() => {
// Send some packets to queue them up (using --test-udp-no-try-send flag)
client.send('Hello');
client.send('World');

assert.strictEqual(typeof client.getSendQueueSize(), 'number');
assert.strictEqual(typeof client.getSendQueueCount(), 'number');

client.close();
server.close();
}));
}));
}

eval('%PrepareFunctionForOptimization(testFastDgram)');
testFastDgram();
eval('%OptimizeFunctionOnNextCall(testFastDgram)');
testFastDgram();

if (common.isDebug) {
const { getV8FastApiCallCount } = internalBinding('debug');
assert.strictEqual(getV8FastApiCallCount('udp.getSendQueueSize'), 1);
assert.strictEqual(getV8FastApiCallCount('udp.getSendQueueCount'), 1);
}