Skip to content

tools: ignore CVE mention when linting release proposals #59037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 13, 2025
Merged

tools: ignore CVE mention when linting release proposals #59037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tools: ignore CVE mention when linting release proposals
  • Loading branch information
@aduh95
aduh95 committed Jul 11, 2025
commit a71d75cb93e7cf0912ca6b0fb575f1c099311157
2 changes: 1 addition & 1 deletion .github/workflows/lint-release-proposal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
EXPECTED_TRAILER="^$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/pull/[[:digit:]]+\$"
echo "Expected trailer format: $EXPECTED_TRAILER"
PR_URL="$(git --no-pager log -1 --format='%(trailers:key=PR-URL,valueonly)')"
echo "Actual: $ACTUAL"
echo "Actual: $PR_URL"
echo "$PR_URL" | grep -E -q "$EXPECTED_TRAILER"

PR_HEAD="$(gh pr view "$PR_URL" --json headRefOid -q .headRefOid)"
Expand Down
1 change: 1 addition & 0 deletions tools/actions/lint-release-proposal-commit-list.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ if (commitListingStart === -1) {
// Normalize for consistent comparison
commitList = commitList
.replaceAll('**(SEMVER-MINOR)** ', '')
.replaceAll(/(?<= - )\*\*\(CVE-\d{4}-\d+\)\*\* (?=\*\*)/g, '')
.replaceAll('\\', '');

let expectedNumberOfCommitsLeft = commitList.match(/\n\* \[/g)?.length ?? 0;
Expand Down
Loading