Skip to content

test: skip tests that cause timeouts on IBM i #59014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 21, 2025
Merged

test: skip tests that cause timeouts on IBM i #59014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: skip tests that cause timeouts on IBM i 
I missed marking a couple of test cases flaky in my previous PR:
#58583

tests missed were:

- parallel.test-inspector-network-content-type
- benchmark.test-benchmark-websocket

After marking the above flaky I re-ran a test build and noticed
the build still failed.

Unfortuantely the build still fails because the build detects that
node process are left behind after the tests, presumably because tests
that spawn child processes are being timed out and only the parent
process is killed off, leaving the child processes behind.

see: #59014 (comment)

We've decided to skip these tests until the underlying issue is
resolved.

The tests being skipped are:
- parallel.test-http-proxy-fetch
- parallel.test-https-proxy-fetch
- benchmark.test-benchmark-websocket
- parallel.test-inspector-network-fetch
- parallel.test-inspector-network-content-type
- es-module.test-wasm-web-api
- parallel.test-fetch
- parallel.test-without-async-context-frame
- report.test-report-exclude-network
  • Loading branch information
@abmusse
abmusse committed Jul 10, 2025
commit db5c57036de4c7ec32663311112ea2a3fd0399f3
2 changes: 2 additions & 0 deletions test/benchmark/benchmark.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@ test-benchmark-crypto: PASS, FLAKY

[$arch==arm]

[$system==ibmi]
test-benchmark-websocket: SKIP
2 changes: 1 addition & 1 deletion test/es-module/es-module.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ test-wasm-web-api: SKIP

[$system==ibmi]
# https://github.com/nodejs/node/issues/58582
test-wasm-web-api: PASS,FLAKY
test-wasm-web-api: SKIP
11 changes: 6 additions & 5 deletions test/parallel/parallel.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,12 @@ test-tls-write-error: PASS, FLAKY
# https://github.com/nodejs/node/issues/48047
test-http-pipeline-flood: SKIP
# https://github.com/nodejs/node/issues/58582
test-http-proxy-fetch: PASS, FLAKY
test-https-proxy-fetch: PASS, FLAKY
test-inspector-network-fetch: PASS, FLAKY
test-fetch: PASS, FLAKY
test-without-async-context-frame: PASS, FLAKY
test-http-proxy-fetch: SKIP
test-https-proxy-fetch: SKIP
test-inspector-network-fetch: SKIP
test-inspector-network-content-type: SKIP
test-fetch: SKIP
test-without-async-context-frame: SKIP
test-process-cpuUsage: PASS, FLAKY


Expand Down
2 changes: 1 addition & 1 deletion test/report/report.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ test-report-fatal-error: PASS, FLAKY

[$system==ibmi]
# https://github.com/nodejs/node/issues/58582
test-report-exclude-network: PASS,FLAKY
test-report-exclude-network: SKIP
Loading