Skip to content

[22.x] win,build: Fix MSVS v17.14 compilation issue on v22 #58902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StefanStojanovic wants to merge 1 commit into from
Closed

[22.x] win,build: Fix MSVS v17.14 compilation issue on v22 #58902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
win,build: fix MSVS v17.14 compilation issue 
Fixes: #58801
  • Loading branch information
@StefanStojanovic
StefanStojanovic committed Jul 2, 2025
commit dd492d00fa10af8c81fb46c71043b91bfaadeb13
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.26',
'v8_embedder_string': '-node.27',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/heap/cppgc/marking-state.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ class MutatorMarkingState final : public BasicMarkingState {
~MutatorMarkingState() override = default;

inline bool MarkNoPush(HeapObjectHeader& header) {
return MutatorMarkingState::BasicMarkingState::MarkNoPush(header);
return BasicMarkingState::MarkNoPush(header);
}

inline void ReTraceMarkedWeakContainer(cppgc::Visitor&, HeapObjectHeader&);
Expand Down
Loading