Skip to content

test: remove reliance on in-tree deps/undici #58866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jun 29, 2025
Merged

test: remove reliance on in-tree deps/undici #58866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove reliance on in-tree deps/undici 
Remove the dependency on the in-tree copy of Undici in `deps/undici`
from `parallel/test-inspector-network-fetch`. For downstream rebuilders
of Node.js using an externalized Undici it is not uncommon to remove
`deps/undici` to ensure that the build is not using the in-tree copy.
  • Loading branch information
@richardlau
richardlau committed Jun 27, 2025
commit c105761eea5282af339c05792e452bc7172c91b0
6 changes: 3 additions & 3 deletions test/parallel/test-inspector-network-fetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Flags: --inspect=0 --experimental-network-inspection
// Flags: --inspect=0 --experimental-network-inspection --expose-internals
'use strict';
const common = require('../common');

Expand All @@ -12,8 +12,8 @@ const https = require('node:https');
const inspector = require('node:inspector/promises');

// Disable certificate validation for the global fetch.
const undici = require('../../deps/undici/src/index.js');
undici.setGlobalDispatcher(new undici.Agent({
const undici = require('internal/deps/undici/undici');
undici.setGlobalDispatcher(new undici.EnvHttpProxyAgent({
connect: {
rejectUnauthorized: false,
},
Expand Down
Loading