Skip to content

test: close dirs in fs-opendir test #58855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jun 28, 2025
Merged

test: close dirs in fs-opendir test #58855

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
014e8dc
test: close dirs in `fs-opendir` test
LiviaMedeiros Jun 26, 2025
49591bc
squash: lint
LiviaMedeiros Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/parallel/test-fs-opendir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@
async function doAsyncIterInvalidCallbackTest() {
const dir = await fs.promises.opendir(testDir);
assert.throws(() => dir.close('not function'), invalidCallbackObj);
dir.close()

Check failure on line 222 in test/parallel/test-fs-opendir.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Missing semicolon
Comment thread
LiviaMedeiros marked this conversation as resolved.
Outdated
}
doAsyncIterInvalidCallbackTest().then(common.mustCall());

Expand Down Expand Up @@ -247,6 +248,7 @@
{
const dir = fs.opendirSync(testDir);
assert.throws(() => dir.read('INVALID_CALLBACK'), /ERR_INVALID_ARG_TYPE/);
dir.close();
}

// Check that concurrent read() operations don't do weird things.
Expand Down
Loading