Skip to content

src: extend --env-file to also accept sections #58782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dario-piotrowicz wants to merge 6 commits into from
Closed

src: extend --env-file to also accept sections #58782

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d6e8866
src: extend dot-env to also handle sections
dario-piotrowicz Jun 21, 2025
e5e6528
fixup! src: extend dot-env to also handle sections
dario-piotrowicz Jun 22, 2025
967e671
fixup! src: extend dot-env to also handle sections
dario-piotrowicz Jun 22, 2025
67b49d0
fixup! src: extend dot-env to also handle sections
dario-piotrowicz Jun 22, 2025
1be2a2f
fixup! src: extend dot-env to also handle sections
dario-piotrowicz Jun 23, 2025
5af1b31
fixup! src: extend dot-env to also handle sections
dario-piotrowicz Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! src: extend dot-env to also handle sections 
validate sections only when present in options object
  • Loading branch information
@dario-piotrowicz
dario-piotrowicz committed Jun 22, 2025
commit e5e652892db34b84f81338cadb4d6a82f50201d3
4 changes: 3 additions & 1 deletion lib/internal/process/per_thread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,9 @@ function wrapProcessMethods(binding) {
function loadEnvFile(path = '.env', options = {}) {
getValidatedPath ??= require('internal/fs/utils').getValidatedPath;
path = getValidatedPath(path);
validateStringArray(options.sections ?? [], 'options.section');
if ('sections' in options) {
validateStringArray(options.sections, 'options.section');
}
_loadEnvFile(path, options.sections ?? []);
}

Expand Down
4 changes: 3 additions & 1 deletion lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,9 @@ function _exceptionWithHostPort(...args) {
*/
function parseEnv(content, options = {}) {
validateString(content, 'content');
validateStringArray(options.sections ?? [], 'options.section');
if ('sections' in options.sections) {
validateStringArray(options.sections, 'options.section');
}
return binding.parseEnv(content, options.sections ?? []);
}

Expand Down
Loading