Skip to content

test: deflake test-buffer-large-size-buffer-alloc #58734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jun 18, 2025
Merged

test: deflake test-buffer-large-size-buffer-alloc #58734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: deflake test-buffer-large-size-buffer-alloc 
Use the error message as another condition to skip the test when the
buffer allocation fails.

Refs: 795dd8eb7988ae38553e
Refs: e9c6004a2d580008082b
  • Loading branch information
@lpinca
lpinca committed Jun 16, 2025
commit 8f1319a53ea487c1b3e2a2d1d6908018e47eaf34
18 changes: 14 additions & 4 deletions test/pummel/test-buffer-large-size-buffer-alloc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,22 @@ common.skipIf32Bits();
const assert = require('node:assert');
const size = 2 ** 31;

let largeBuffer;

// Test Buffer.alloc with size larger than integer range
try {
assert.throws(() => Buffer.alloc(size).toString('utf8'), { code: 'ERR_STRING_TOO_LONG' });
largeBuffer = Buffer.alloc(size);
} catch (e) {
if (e.code !== 'ERR_MEMORY_ALLOCATION_FAILED') {
throw e;
if (
e.code === 'ERR_MEMORY_ALLOCATION_FAILED' ||
/Array buffer allocation failed/.test(e.message)
) {
common.skip('insufficient space for Buffer.alloc');
}
common.skip('insufficient space for Buffer.alloc');

throw e;
}

assert.throws(() => largeBuffer.toString('utf8'), {
code: 'ERR_STRING_TOO_LONG',
});
Loading