Skip to content

repl: avoid deprecated require.extensions in tab completion #58653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Jun 23, 2025
Merged

repl: avoid deprecated require.extensions in tab completion #58653

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b7ff87
repl: avoid deprecated `require.extensions` in tab completion
gulbaki Jun 9, 2025
00a2537
equire module moved up
gulbaki Jun 10, 2025
5cb5079
refactor: replace deprecated Module reference with CJSModule in REPL …
gulbaki Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: replace deprecated Module reference with CJSModule in REPL … 
…completion
  • Loading branch information
@gulbaki
gulbaki committed Jun 11, 2025
commit 5cb50796453925b705c2bbea6a9c8c6017d0c38a
3 changes: 1 addition & 2 deletions lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ const {
kLastCommandErrored,
} = require('internal/readline/interface');
let nextREPLResourceNumber = 1;
const Module = require('module');
// This prevents v8 code cache from getting confused and using a different
// cache from a resource of the same name
function getREPLResourceName() {
Expand Down Expand Up @@ -1361,7 +1360,7 @@ function complete(line, callback) {
filter = completeOn;
if (this.allowBlockingCompletions) {
const subdir = match[2] || '';
const extensions = ObjectKeys(Module._extensions);
const extensions = ObjectKeys(CJSModule._extensions);
const indexes = ArrayPrototypeMap(extensions,
(extension) => `index${extension}`);
ArrayPrototypePush(indexes, 'package.json', 'index');
Expand Down
Loading