Skip to content

module: allow cycles in require() in the CJS handling in ESM loader #58598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jun 11, 2025
Merged

module: allow cycles in require() in the CJS handling in ESM loader #58598

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
445f2e0
module: allow cycles in require() in the CJS handling in ESM loader
joyeecheung Jun 6, 2025
4d6f693
fixup! module: allow cycles in require() in the CJS handling in ESM l…
joyeecheung Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! module: allow cycles in require() in the CJS handling in ESM l… 
…oader
  • Loading branch information
@joyeecheung
joyeecheung committed Jun 9, 2025
commit 4d6f69300c04d6fb5e20ed78cb8259f336737f9f
2 changes: 1 addition & 1 deletion test/es-module/test-import-preload-require-cycle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spawnSyncAndAssert(
process.execPath,
[
'--import',
fixtures.path('import-require-cycle/preload.mjs'),
fixtures.fileURL('import-require-cycle/preload.mjs'),
fixtures.path('import-require-cycle/c.js'),
],
{
Expand Down
Loading