Skip to content

[v22.x backport] worker: make Worker async disposable #58455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 2 commits into from
Jul 28, 2025
Merged

[v22.x backport] worker: make Worker async disposable #58455

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dbc6b2
worker: make Worker async disposable
jasnell May 24, 2025
66fccc2
test: add test for async disposable worker thread
jasnell May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
worker: make Worker async disposable 
PR-URL: #58385
Backport-PR-URL: #58455
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
  • Loading branch information
@jasnell @aduh95
jasnell authored and aduh95 committed Jul 28, 2025
commit 8dbc6b210f8ed666cc93f7709141d4ca87367429
8 changes: 8 additions & 0 deletions doc/api/worker_threads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1846,6 +1846,14 @@ Calling `unref()` on a worker allows the thread to exit if this is the only
active handle in the event system. If the worker is already `unref()`ed calling
`unref()` again has no effect.

### `worker[Symbol.asyncDispose]()`

<!-- YAML
added: REPLACEME
-->

Alias for [`worker.terminate()`][].

## Notes

### Synchronous blocking of stdio
Expand Down
6 changes: 5 additions & 1 deletion lib/internal/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const {
const { createMainThreadPort, destroyMainThreadPort } = require('internal/worker/messaging');
const { deserializeError } = require('internal/error_serdes');
const { fileURLToPath, isURL, pathToFileURL } = require('internal/url');
const { kEmptyObject } = require('internal/util');
const { kEmptyObject, SymbolAsyncDispose } = require('internal/util');
const { validateArray, validateString } = require('internal/validators');
const {
throwIfBuildingSnapshot,
Expand Down Expand Up @@ -406,6 +406,10 @@ class Worker extends EventEmitter {
});
}

async [SymbolAsyncDispose]() {
await this.terminate();
}

ref() {
if (this[kHandle] === null) return;

Expand Down