Skip to content

lib: avoid event override by assignment #58315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erights wants to merge 10 commits into
base: main
Choose a base branch
from
+46 −9
Open

lib: avoid event override by assignment #58315

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a5dce87
lib: avoid event override by assignment
erights May 13, 2025
c7a261a
fixup! Review suggestion
erights Jun 19, 2025
e57c53b
fixup! Review suggestion
erights Jun 19, 2025
e7aeac9
fixup! Review suggestion
erights Jun 19, 2025
640ac9d
fixup! review suggestions
erights Jun 19, 2025
c60730c
fixup! Review suggestion
erights Jun 19, 2025
fae8feb
fixup! remove unused Boolean
erights Jun 20, 2025
a91d6b5
Merge branch 'main' into markm-avoid-event-override-by-assignment
erights Aug 12, 2025
577a821
fixup! merge repair
erights Aug 12, 2025
f1958ee
fixup! restore Boolean
erights Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! Review suggestion 
Co-authored-by: Jordan Harband <ljharb@gmail.com>
  • Loading branch information
@erights @ljharb
erights and ljharb authored Jun 19, 2025
commit e7aeac9b652d9f24d9e064f27c7c23768722e150
4 changes: 3 additions & 1 deletion lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,9 @@ EventEmitter.init = function(opts) {
validateBoolean(opts.captureRejections, 'options.captureRejections');
ObjectDefineProperty(this, kCapture, {
__proto__: null,
value: Boolean(opts.captureRejections),
configurable: true,
value: !!opts.captureRejections,
writable: true,
});
Comment thread
erights marked this conversation as resolved.
} else {
// Assigning the kCapture property directly saves an expensive
Expand Down