Skip to content

test: fix test-cluster-worker-kill #5814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santigimeno wants to merge 1 commit into from
Closed

test: fix test-cluster-worker-kill #5814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix test-cluster-worker-kill 
Don't check that the `disconnect` event is emitted before the `exit`
event as the order is not guaranteed.
  • Loading branch information
@santigimeno
santigimeno committed Mar 20, 2016
commit 5dae73414bf1a72d2b2ced435d286b940bfe83b1
23 changes: 3 additions & 20 deletions test/parallel/test-cluster-worker-kill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ if (cluster.isWorker) {
results.cluster_exitCode = worker.process.exitCode;
results.cluster_signalCode = worker.process.signalCode;
results.cluster_emitExit += 1;
assert.ok(results.cluster_emitDisconnect,
"cluster: 'exit' event before 'disconnect' event");
});

// Check worker events and properties
Expand All @@ -77,26 +75,11 @@ if (cluster.isWorker) {
results.worker_signalCode = signalCode;
results.worker_emitExit += 1;
results.worker_died = !alive(worker.process.pid);
assert.ok(results.worker_emitDisconnect,
"worker: 'exit' event before 'disconnect' event");

process.nextTick(function() { finish_test(); });
});

var finish_test = function() {
try {
checkResults(expected_results, results);
} catch (exc) {
console.error('FAIL: ' + exc.message);
if (exc.name != 'AssertionError') {
console.trace(exc);
}

process.exit(1);
return;
}
process.exit(0);
};
process.on('exit', function() {
checkResults(expected_results, results);
});
}

// some helper functions ...
Expand Down