Skip to content

tools: edit create-release-proposal workflow to handle pr body length #57841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Apr 14, 2025
Merged

tools: edit create-release-proposal workflow to handle pr body length #57841

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca89abd
tools: edit create-release-proposal workflow to handle pr body length
elvessilvavieira Apr 11, 2025
9014f9a
tools: improve performance of PR body length handling
elvessilvavieira Apr 12, 2025
125e5a6
tools: fix create-release-proposal workflow
elvessilvavieira Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tools/actions/create-release-proposal.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ HEAD_SHA="$(git rev-parse HEAD^)"

TITLE="$(git log -1 --format=%s)"

# Use a temporary file for the PR body
TEMP_BODY="$(awk "/## ${RELEASE_DATE}/,/^<a id=/{ if (!/^<a id=/) print }" "doc/changelogs/CHANGELOG_V${RELEASE_LINE}.md")"
TEMP_BODY="$(awk -v MAX_BODY_LENGTH="65536" \
"/^## ${RELEASE_DATE}/,/^<a id=/{ if (/^<a id=/) {exit;} if (output_length += length(\$0) > MAX_BODY_LENGTH) {exit 1;} print }" \
Comment thread
elvessilvavieira marked this conversation as resolved.
Outdated
"doc/changelogs/CHANGELOG_V${RELEASE_LINE}.md" || echo "…")"

# Create the proposal branch
gh api \
Expand Down
Loading