Skip to content

util: fix formatting of objects with built-in Symbol.toPrimitive #57832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Apr 17, 2025
Merged

util: fix formatting of objects with built-in Symbol.toPrimitive #57832

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
74e49ba
util: fix formatting of objects with built-in Symbol.toPrimitive
islandryu Apr 11, 2025
9941038
add symbol test
islandryu Apr 11, 2025
140a6f2
handle the case toPrimitive is defined in prototype
islandryu Apr 12, 2025
476a700
add test
islandryu Apr 12, 2025
5b0ac9b
add comment
islandryu Apr 12, 2025
412347c
fix to not call unnecessary hasOwnProperty
islandryu Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@islandryu
islandryu committed Apr 12, 2025
commit 476a7001aaecadc53f4fb3fb2b846b92e71d4daa
32 changes: 30 additions & 2 deletions test/parallel/test-util-format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,13 @@ assert.strictEqual(util.format('%s', -Infinity), '-Infinity');
return 'hasToStringButNoToPrimitive';
};

const obj = new hasToStringButNoToPrimitive();
let obj = new hasToStringButNoToPrimitive();
assert.strictEqual(util.format('%s', obj.toString()), 'hasToStringButNoToPrimitive');

function inheritsFromHasToStringButNoToPrimitive() {}
Object.setPrototypeOf(inheritsFromHasToStringButNoToPrimitive.prototype,
hasToStringButNoToPrimitive.prototype);
obj = new inheritsFromHasToStringButNoToPrimitive();
assert.strictEqual(util.format('%s', obj.toString()), 'hasToStringButNoToPrimitive');
}

Expand All @@ -317,8 +323,30 @@ assert.strictEqual(util.format('%s', -Infinity), '-Infinity');
return 'hasToPrimitiveButNoToString';
};

const obj = new hasToPrimitiveButNoToString();
let obj = new hasToPrimitiveButNoToString();
assert.strictEqual(util.format('%s', obj[Symbol.toPrimitive]()), 'hasToPrimitiveButNoToString');
function inheritsFromHasToPrimitiveButNoToString() {}
Object.setPrototypeOf(inheritsFromHasToPrimitiveButNoToString.prototype,
hasToPrimitiveButNoToString.prototype);
obj = new inheritsFromHasToPrimitiveButNoToString();
assert.strictEqual(util.format('%s', obj[Symbol.toPrimitive]()), 'hasToPrimitiveButNoToString');
}

{
function hasBothToStringAndToPrimitive() {}
hasBothToStringAndToPrimitive.prototype.toString = function() {
return 'toString';
};
hasBothToStringAndToPrimitive.prototype[Symbol.toPrimitive] = function() {
return 'toPrimitive';
};
let obj = new hasBothToStringAndToPrimitive();
assert.strictEqual(util.format('%s', obj.toString()), 'toString');
function inheritsFromHasBothToStringAndToPrimitive() {}
Object.setPrototypeOf(inheritsFromHasBothToStringAndToPrimitive.prototype,
hasBothToStringAndToPrimitive.prototype);
obj = new inheritsFromHasBothToStringAndToPrimitive();
assert.strictEqual(util.format('%s', obj.toString()), 'toString');
}

// JSON format specifier
Expand Down
Loading