Skip to content

ffi: Initial implementation #57761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tianxiadys wants to merge 4 commits into from
Closed

ffi: Initial implementation #57761

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f7abd8
node:ffi
tianxiadys Apr 5, 2025
e92a2d8
fixed-0407
tianxiadys Apr 7, 2025
06e756c
fixed-0407
tianxiadys Apr 7, 2025
56224f8
fixed-0407
tianxiadys Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixed-0407
  • Loading branch information
@tianxiadys
tianxiadys committed Apr 7, 2025
commit 56224f88ceed529c573c8c6a164136aef75ecba7
2 changes: 1 addition & 1 deletion lib/ffi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class UnsafeLibrary {
#library;

constructor(filename, defMap) {
const symbols = {};
const symbols = Object.create(null);
const library = LoadLibrary(filename);
if (!library) {
throw new ERR_FFI_LIBRARY_LOAD_FAILED(filename);
Expand Down
2 changes: 1 addition & 1 deletion src/permission/permission.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ Permission::Permission() : enabled_(false) {
std::shared_ptr<PermissionBase> wasi = std::make_shared<WASIPermission>();
#define V(Name, _, __, ___) \
nodes_.insert(std::make_pair(PermissionScope::k##Name, ffi));
FILESYSTEM_PERMISSIONS(V)
FFI_PERMISSIONS(V)
#undef V
#define V(Name, _, __, ___) \
nodes_.insert(std::make_pair(PermissionScope::k##Name, fs));
Expand Down