Skip to content

src: do not pass nullptr to std::string ctor #57354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Mar 9, 2025
Merged

src: do not pass nullptr to std::string ctor #57354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: do not pass nullptr to std::string ctor 
fixes -Wnonnull warning on some compilers
  • Loading branch information
@ckerr
ckerr committed Mar 7, 2025
commit c8a3a3ddcfa13cab848b63d773346e83123ffe70
2 changes: 1 addition & 1 deletion src/debug_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ class Win32SymbolDebuggingContext final : public NativeSymbolDebuggingContext {
USE(GetLastError());
#endif // DEBUG
}
return nullptr;
return {};
}

SymbolInfo LookupSymbol(void* address) override {
Expand Down