Skip to content

test: refactor test runner run plan tests #57304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
Mar 10, 2025
Merged

test: refactor test runner run plan tests #57304

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d28ef6a
test: test runner run plan
pmarchini Feb 24, 2025
245ad8b
test: add timeout tests for t.plan
pmarchini Mar 3, 2025
e9ea918
test: add input validation
pmarchini Mar 3, 2025
dab9a7f
test_runner: replace test-runner-run-plan with test-runner-plan
pmarchini Mar 3, 2025
48c5c4f
test_runner: remove duplicate tests
pmarchini Mar 4, 2025
ad45621
test: remove forceExit option in test runner plans
pmarchini Mar 4, 2025
97f1057
test: update testFixtures path
pmarchini Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add input validation
  • Loading branch information
@pmarchini
pmarchini committed Mar 3, 2025
commit e9ea9185e662581acba3dccc7c3fce625743ffae
31 changes: 30 additions & 1 deletion test/parallel/test-runner-run-plan.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,35 @@ import { join } from 'node:path';

const testFixtures = fixtures.path('test-runner');

describe('input validation', () => {
it('throws if options is not an object', (t) => {
t.assert.throws(() => {
t.plan(1, null);
}, {
code: 'ERR_INVALID_ARG_TYPE',
message: /The "options" argument must be of type object/,
});
});

it('throws if options.wait is not a number or a boolean', (t) => {
t.assert.throws(() => {
t.plan(1, { wait: 'foo' });
}, {
code: 'ERR_INVALID_ARG_TYPE',
message: /The "options\.wait" property must be one of type boolean or number\. Received type string/,
});
});

it('throws if count is not a number', (t) => {
t.assert.throws(() => {
t.plan('foo');
}, {
code: 'ERR_INVALID_ARG_TYPE',
message: /The "count" argument must be of type number/,
});
});
});

describe('test planning', () => {
it('should pass when assertions match plan', async () => {
const stream = run({
Expand Down Expand Up @@ -85,7 +114,7 @@ describe('test planning', () => {

stream.on('test:fail', common.mustNotCall());
stream.on('test:pass', common.mustCall(3)); // Parent + 2 levels of nesting

// eslint-disable-next-line no-unused-vars
for await (const _ of stream);
});
Expand Down