Skip to content

src: reduce string allocations on sqlite #57227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Mar 1, 2025
Merged

src: reduce string allocations on sqlite #57227

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12e4eef
src: reduce string allocations on sqlite
anonrig Feb 27, 2025
8a206df
Apply suggestions from code review
anonrig Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: James M Snell <jasnell@gmail.com>
  • Loading branch information
@anonrig @jasnell
anonrig and jasnell authored Feb 27, 2025
commit 8a206df14823931cd6502a96858770e4b11a8f5e
4 changes: 2 additions & 2 deletions src/node_sqlite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ std::optional<std::string> ValidateDatabasePath(Environment* env,
return str.find('\0') != std::string_view::npos;
};
if (path->IsString()) {
auto location = Utf8Value(env->isolate(), path.As<String>());
Utf8Value location(env->isolate(), path.As<String>());
if (!has_null_bytes(location.ToStringView())) {
return location.ToString();
}
Expand All @@ -615,7 +615,7 @@ std::optional<std::string> ValidateDatabasePath(Environment* env,
Local<Value> href;
if (url->Get(env->context(), env->href_string()).ToLocal(&href) &&
href->IsString()) {
const auto location_value = Utf8Value(env->isolate(), href.As<String>());
Utf8Value location_value(env->isolate(), href.As<String>());
auto location = location_value.ToStringView();
if (!has_null_bytes(location)) {
CHECK(ada::can_parse(location));
Expand Down