Skip to content

test: resolve race condition in test-net-write-fully-async-* #57022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Feb 25, 2025
Merged

test: resolve race condition in test-net-write-fully-async-* #57022

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b41341
test: resolve race condition in test-net-write-fully-async-*
mcollina Feb 13, 2025
a3c5d6d
fixup
mcollina Feb 13, 2025
15c1690
fixup: switch to .end()
mcollina Feb 15, 2025
94596f7
fixup
mcollina Feb 15, 2025
2f9f49c
Update test-net-write-fully-async-buffer.js
mcollina Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
  • Loading branch information
@mcollina
mcollina committed Feb 15, 2025
commit 94596f7d5caefd2c4a1aa8afa4287cb3f730fcb9
2 changes: 1 addition & 1 deletion test/parallel/test-net-write-fully-async-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ const data = Buffer.alloc(1000000);

const server = net.createServer(common.mustCall(function(conn) {
conn.resume();
server.close();
})).listen(0, common.mustCall(function() {
const conn = net.createConnection(this.address().port, common.mustCall(() => {
let count = 0;

function writeLoop() {
if (count++ === 200) {
Comment thread
mcollina marked this conversation as resolved.
Outdated
conn.end();
server.close();
return;
}

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-net-write-fully-async-hex-string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ const data = Buffer.alloc(1000000).toString('hex');

const server = net.createServer(common.mustCall(function(conn) {
conn.resume();
server.close();
})).listen(0, common.mustCall(function() {
const conn = net.createConnection(this.address().port, common.mustCall(() => {
let count = 0;

function writeLoop() {
if (count++ === 20) {
conn.end();
server.close();
return;
}

Expand Down