Skip to content

src: fix process exit listeners not receiving unsettled tla codes #56872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 10 commits into from
Mar 8, 2025
Merged

src: fix process exit listeners not receiving unsettled tla codes #56872

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bbc5cbd
src: fix process exit listeners not receiving unsettled tla codes
dario-piotrowicz Feb 2, 2025
0dc8965
src: fix process exit listeners not receiving unsettled tla codes
dario-piotrowicz Feb 2, 2025
a124fbf
Update doc/api/process.md
dario-piotrowicz Feb 12, 2025
422df04
Update doc/api/process.md
dario-piotrowicz Feb 12, 2025
e6a3409
remove local `exitCode` variable
dario-piotrowicz Feb 12, 2025
66449f7
update tests structure as suggested
dario-piotrowicz Mar 2, 2025
50e7606
Update test/es-module/test-esm-tla-unfinished.mjs
dario-piotrowicz Mar 2, 2025
dc8258e
consistently destructure `stderr` before `stdout`
dario-piotrowicz Mar 2, 2025
e56faf7
remove unnecessary test
dario-piotrowicz Mar 2, 2025
14b759a
test stderr` first
dario-piotrowicz Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test stderr` first
  • Loading branch information
@dario-piotrowicz
dario-piotrowicz committed Mar 2, 2025
commit 14b759ad64dbc1fa756cc2d4f31a73579df63e94
4 changes: 2 additions & 2 deletions test/es-module/test-esm-tla-unfinished.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ describe('ESM: unsettled and rejected promises', { concurrency: !process.env.TES
fixtures.path('es-modules/tla/unresolved.mjs'),
]);

assert.strictEqual(stdout, 'the exit listener received code: 13\n');
assert.match(stderr, /Warning: Detected unsettled top-level await at.+unresolved\.mjs:5\b/);
assert.match(stderr, /await new Promise/);
assert.strictEqual(stdout, 'the exit listener received code: 13\n');
assert.strictEqual(code, 13);
});

Expand Down Expand Up @@ -169,11 +169,11 @@ describe('ESM: unsettled and rejected promises', { concurrency: !process.env.TES
fixtures.path('es-modules/tla/unresolved-with-listener.mjs'),
]);

assert.match(stderr, /Warning: Detected unsettled top-level await at/);
assert.strictEqual(stdout,
'the exit listener received code: 13\n' +
'process.exitCode inside the exist listener: 13\n'
);
assert.match(stderr, /Warning: Detected unsettled top-level await at/);
assert.strictEqual(code, 13);
});

Expand Down