Skip to content

test: fix race condition in test-child-process-bad-stdio #56845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Feb 3, 2025
Merged

test: fix race condition in test-child-process-bad-stdio #56845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix race condition in test-child-process-bad-stdio 
test-child-process-bad-stdio.js contains a race condition between
a timeout in the test process and a timeout in the spawned child
process. This commit addresses the race condition by having the
child process wait indefinitely to be killed.
  • Loading branch information
@cjihrig
cjihrig committed Feb 2, 2025
commit dd93a471f3fe8bf7ed7841c6985a553948aab90c
2 changes: 1 addition & 1 deletion test/parallel/test-child-process-bad-stdio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const common = require('../common');

if (process.argv[2] === 'child') {
setTimeout(() => {}, common.platformTimeout(100));
setTimeout(() => {}, common.platformTimeout(1000));
return;
}

Expand Down