Skip to content

deps: update V8 to 13.2.152.37 #56842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 19 commits into from
Closed

deps: update V8 to 13.2.152.37 #56842

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
157eb4e
deps: update V8 to 13.2.152.38
targos Feb 5, 2025
3cc22fe
build: reset embedder string to "-node.0"
targos Feb 5, 2025
14cbb2c
src: update NODE_MODULE_VERSION to 135
targos Jan 31, 2025
05bc962
deps: always define V8_EXPORT_PRIVATE as no-op
targos Sep 21, 2022
8159f62
deps: disable V8 concurrent sparkplug compilation
targos Apr 6, 2023
67a2a64
deps: patch V8 to avoid duplicated zlib symbol
targos Sep 16, 2023
a6afdf4
deps: patch V8 to support compilation with MSVC
StefanStojanovic Apr 21, 2024
adf80de
deps: fix FP16 bitcasts.h
StefanStojanovic May 28, 2024
d3e89c2
deps: always define V8_NODISCARD as no-op
targos Aug 8, 2024
c7b2eec
deps: define V8_PRESERVE_MOST as no-op on Windows
StefanStojanovic Dec 16, 2024
beae108
deps: V8: cherry-pick 9ab40592f697
kxxt Feb 4, 2025
f50bedd
build: remove support for s390 32-bit
richardlau Sep 18, 2024
ef3b92e
build: enable shared RO heap with ptr compression
targos Sep 21, 2024
9b297c3
tools: update V8 gypfiles for 13.1
targos Sep 25, 2024
c5ba65a
tools: update V8 gypfiles for 13.2
targos Oct 28, 2024
9d78e22
Revert "test: disable fast API call count checks"
targos Jan 31, 2025
b3c3d46
test: update test-linux-perf-logger
targos Feb 4, 2025
cae04fd
build: add `/bigobj` to compile V8 on Windows
targos Feb 5, 2025
9d1f6d4
fixup! test: update test-linux-perf-logger
targos Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: update test-linux-perf-logger 
New V8 version includes more information about regular expressions.
  • Loading branch information
@targos
targos committed Feb 5, 2025
commit b3c3d4680b607de5ab025e8da8355ce285eecb41
31 changes: 17 additions & 14 deletions test/v8-updates/test-linux-perf-logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ const testCases = [
title: '--perf-basic-prof interpreted',
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--no-opt'],
matches: [
'~functionOne .+/linux-perf-logger.js',
'~functionTwo .+/linux-perf-logger.js',
'test-regex',
'JS:~functionOne .+/linux-perf-logger.js',
'JS:~functionTwo .+/linux-perf-logger.js',
"RegExp\\.> src: 'test-regex' flags: 'gi'",
],
noMatches: ['\\*functionOne', '\\*functionTwo'],
},
Expand All @@ -55,29 +55,32 @@ const testCases = [
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan',
'--minimum-invocations-before-optimization=0'],
matches: [
'test-regex',
'~functionOne .+/linux-perf-logger.js',
'~functionTwo .+/linux-perf-logger.js',
'\\*functionOne .+/linux-perf-logger.js',
'\\*functionTwo .+/linux-perf-logger.js',
"RegExp\\.> src: 'test-regex' flags: 'gi'",
'JS:~functionOne .+/linux-perf-logger.js',
'JS:~functionTwo .+/linux-perf-logger.js',
'JS:\\*functionOne .+/linux-perf-logger.js',
'JS:\\*functionTwo .+/linux-perf-logger.js',
],
noMatches: [],
},
{
title: '--perf-basic-prof-only-functions interpreted',
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--no-opt'],
matches: ['~functionOne .+/linux-perf-logger.js', '~functionTwo .+/linux-perf-logger.js'],
matches: [
'JS:~functionOne .+/linux-perf-logger.js',
'~functionTwo .+/linux-perf-logger.js',
],
noMatches: ['\\*functionOne', '\\*functionTwo', 'test-regex'],
},
{
title: '--perf-basic-prof-only-functions compiled',
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan',
'--minimum-invocations-before-optimization=0'],
matches: [
'~functionOne .+/linux-perf-logger.js',
'~functionTwo .+/linux-perf-logger.js',
'\\*functionOne .+/linux-perf-logger.js',
'\\*functionTwo .+/linux-perf-logger.js',
'JS:~functionOne .+/linux-perf-logger.js',
'JS:~functionTwo .+/linux-perf-logger.js',
'JS:\\*functionOne .+/linux-perf-logger.js',
'JS:\\*functionTwo .+/linux-perf-logger.js',
],
noMatches: ['test-regex'],
},
Expand Down Expand Up @@ -110,7 +113,7 @@ function runTest(test) {

const hexRegex = '[a-fA-F0-9]+';
for (const testRegex of test.matches) {
const lineRegex = new RegExp(`${hexRegex} ${hexRegex}.*:${testRegex}`);
const lineRegex = new RegExp(`${hexRegex} ${hexRegex}.* ${testRegex}`);
if (!lineRegex.test(report.perfMap)) {
report.errors.push(`Expected to match ${lineRegex}`);
}
Expand Down