Skip to content

inspector: support for worker inspection in chrome devtools #56759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 16 commits into from
May 12, 2025
Merged

inspector: support for worker inspection in chrome devtools #56759

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
525a2d2
inspector: support for worker inspection in chrome devtools
islandryu Jan 25, 2025
cab3f96
fix/test
islandryu Jan 27, 2025
fafadd0
format
islandryu Jan 29, 2025
234a139
format
islandryu Jan 30, 2025
01011f6
fix test
islandryu Feb 3, 2025
cde7b09
support setAutoAttach
islandryu Feb 8, 2025
b669db4
fix stoi error
islandryu Feb 9, 2025
d8747cf
add permission option test
islandryu Mar 31, 2025
3f0b1b4
Update doc/api/cli.md
islandryu Mar 31, 2025
f0dc69f
fix doc
islandryu Mar 31, 2025
85e78eb
Update src/inspector/target_agent.h
islandryu Apr 14, 2025
81f91a8
fix string_view
islandryu Apr 14, 2025
86e20df
fix lint
islandryu Apr 14, 2025
d31fa3e
format
islandryu Apr 15, 2025
f2cb355
Update src/inspector/node_inspector.gypi
islandryu Apr 17, 2025
5c31756
change worker name
islandryu Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format
  • Loading branch information
@islandryu
islandryu committed Apr 15, 2025
commit d31fa3eb1df83b151e737cdf85648762cadd35d4
8 changes: 4 additions & 4 deletions src/inspector/target_agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ class WorkerTargetDelegate : public WorkerDelegate {
};

std::unique_ptr<Target::TargetInfo> createTargetInfo(
const std::string_view target_id,
const std::string_view type,
const std::string_view title,
const std::string_view url) {
const std::string_view target_id,
const std::string_view type,
const std::string_view title,
const std::string_view url) {
return Target::TargetInfo::create()
.setTargetId(std::string(target_id))
.setType(std::string(type))
Expand Down
Loading