Skip to content

test: cleanup and simplify test-crypto-aes-wrap #56748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jan 26, 2025
Merged

test: cleanup and simplify test-crypto-aes-wrap #56748

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16a9734
test: cleanup and simplify test-crypto-aes-wrap
jasnell Jan 24, 2025
7ee7116
Update test/parallel/test-crypto-aes-wrap.js
jasnell Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: cleanup and simplify test-crypto-aes-wrap 
* Add comment explaining purpose of the test
* Eliminate duplicative/extraneous buffer allocations
  • Loading branch information
@jasnell
jasnell committed Jan 24, 2025
commit 16a9734362d344750079603b1cd047ef453f346a
58 changes: 28 additions & 30 deletions test/parallel/test-crypto-aes-wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,62 +1,60 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
if (!common.hasCrypto) {
common.skip('missing crypto');
}

// Tests the that the AES wrap and unwrap functions are working correctly.
Comment thread
jasnell marked this conversation as resolved.
Outdated

const assert = require('assert');
const crypto = require('crypto');

const test = [
const ivShort = Buffer.from('3fd838af', 'hex');
const ivLong = Buffer.from('3fd838af4093d749', 'hex');
const key1 = Buffer.from('b26f309fbe57e9b3bb6ae5ef31d54450', 'hex');
const key2 = Buffer.from('40978085d68091f7dfca0d7dfc7a5ee76d2cc7f2f345a304', 'hex');
const key3 = Buffer.from('29c9eab5ed5ad44134a1437fe2e673b4d88a5b7c72e68454fea08721392b7323', 'hex');

[
{
algorithm: 'aes128-wrap',
key: 'b26f309fbe57e9b3bb6ae5ef31d54450',
iv: '3fd838af4093d749',
key: key1,
iv: ivLong,
text: '12345678123456781234567812345678'
},
{
algorithm: 'id-aes128-wrap-pad',
key: 'b26f309fbe57e9b3bb6ae5ef31d54450',
iv: '3fd838af',
key: key1,
iv: ivShort,
text: '12345678123456781234567812345678123'
},
{
algorithm: 'aes192-wrap',
key: '40978085d68091f7dfca0d7dfc7a5ee76d2cc7f2f345a304',
iv: '3fd838af4093d749',
key: key2,
iv: ivLong,
text: '12345678123456781234567812345678'
},
{
algorithm: 'id-aes192-wrap-pad',
key: '40978085d68091f7dfca0d7dfc7a5ee76d2cc7f2f345a304',
iv: '3fd838af',
key: key2,
iv: ivShort,
text: '12345678123456781234567812345678123'
},
{
algorithm: 'aes256-wrap',
key: '29c9eab5ed5ad44134a1437fe2e673b4d88a5b7c72e68454fea08721392b7323',
iv: '3fd838af4093d749',
key: key3,
iv: ivLong,
text: '12345678123456781234567812345678'
},
{
algorithm: 'id-aes256-wrap-pad',
key: '29c9eab5ed5ad44134a1437fe2e673b4d88a5b7c72e68454fea08721392b7323',
iv: '3fd838af',
key: key3,
iv: ivShort,
text: '12345678123456781234567812345678123'
},
];

test.forEach((data) => {
const cipher = crypto.createCipheriv(
data.algorithm,
Buffer.from(data.key, 'hex'),
Buffer.from(data.iv, 'hex'));
const ciphertext = cipher.update(data.text, 'utf8');

const decipher = crypto.createDecipheriv(
data.algorithm,
Buffer.from(data.key, 'hex'),
Buffer.from(data.iv, 'hex'));
const msg = decipher.update(ciphertext, 'buffer', 'utf8');

assert.strictEqual(msg, data.text, `${data.algorithm} test case failed`);
].forEach(({ algorithm, key, iv, text }) => {
const cipher = crypto.createCipheriv(algorithm, key, iv);
const decipher = crypto.createDecipheriv(algorithm, key, iv);
const msg = decipher.update(cipher.update(text, 'utf8'), 'buffer', 'utf8');
assert.strictEqual(msg, text, `${algorithm} test case failed`);
});