Skip to content

benchmark: add validateStream to styleText bench #56556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jan 12, 2025
Merged

benchmark: add validateStream to styleText bench #56556

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23812f5
benchmark: add validateStream to styleText bench
RafaelGSS Jan 10, 2025
6580f3f
fixup! benchmark: add validateStream to styleText bench
RafaelGSS Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! benchmark: add validateStream to styleText bench
  • Loading branch information
@RafaelGSS
RafaelGSS committed Jan 11, 2025
commit 6580f3fd5dc4b4d9f2d0b94cba3eb0442f7dea81
5 changes: 3 additions & 2 deletions benchmark/util/style-text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
const common = require('../common.js');

const { styleText } = require('node:util');
const assert = require('node:assert');

const bench = common.createBenchmark(main, {
messageType: ['string', 'number', 'boolean', 'invalid'],
Expand Down Expand Up @@ -30,9 +31,9 @@ function main({ messageType, format, validateStream, n }) {

bench.start();
for (let i = 0; i < n; i++) {
let colored = ''
let colored = '';
try {
colored = util.styleText(format, str, { validateStream });
colored = styleText(format, str, { validateStream });
assert.ok(colored); // Attempt to avoid dead-code elimination
} catch {
// eslint-disable no-empty
Expand Down