Skip to content

module: fix async resolution error within the sync findPackageJSON #56382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 8 commits into from
Dec 31, 2024
Merged

module: fix async resolution error within the sync findPackageJSON #56382

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a7b91e3
module: fix async resolution error within the sync `findPackageJSON`
JakobJingleheimer Dec 28, 2024
10fa02d
implement resolveSync with defaultResolve & polish test-cases
aduh95 Dec 28, 2024
1619459
revert basic implementation of resolveSync; use defaultResolve directly
JakobJingleheimer Dec 30, 2024
9cef635
de-lint
JakobJingleheimer Dec 30, 2024
e3972d2
add (temporary) limitation caveat to `findPackageJSON` doc entry
JakobJingleheimer Dec 30, 2024
9ea1146
english → american 😅
JakobJingleheimer Dec 30, 2024
fcb4470
fix typos
JakobJingleheimer Dec 30, 2024
208fa8f
other typos
JakobJingleheimer Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typos 
Co-authored-by: Jordan Harband <ljharb@gmail.com>
  • Loading branch information
@JakobJingleheimer @ljharb
JakobJingleheimer and ljharb authored Dec 30, 2024
commit fcb44708dbc7b1516c518be76b86318d00256bd5
6 changes: 3 additions & 3 deletions doc/api/module.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,12 @@ added: v23.2.0
is a package, the package's root `package.json`; when a relative or unresolved, the closest
`package.json` to the `specifier`.

> **Caveat**: Do not use this to try to determine module format. There are many things effecting
> **Caveat**: Do not use this to try to determine module format. There are many things affecting
> that determination; the `type` field of package.json is the _least_ definitive (ex file extension
> superceeds it, and a loader hook superceeds that).
> supercedes it, and a loader hook supercedes that).
Comment thread
JakobJingleheimer marked this conversation as resolved.
Outdated
Comment thread
ljharb marked this conversation as resolved.
Outdated

> **Caveat**: This currently leverages only the built-in default resolver; if
> [`resolve` customization hooks][resolve hook] are registered, they will not effect the resolution.
> [`resolve` customization hooks][resolve hook] are registered, they will not affect the resolution.
> This may change in the future.

```text
Expand Down