Skip to content

module: only emit require(esm) warning under --trace-require-module #56194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

module: only emit require(esm) warning under --trace-require-module #56194

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dde51d
module: only emit require(esm) warning under --trace-require-module
joyeecheung Dec 9, 2024
9351661
fixup! module: only emit require(esm) warning under --trace-require-m…
joyeecheung Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! module: only emit require(esm) warning under --trace-require-m… 
…odule
  • Loading branch information
@joyeecheung
joyeecheung committed Dec 9, 2024
commit 93516613362d4a618dfdc27aa8bc0bdbe295d38e
3 changes: 1 addition & 2 deletions src/node_options.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,7 @@ void EnvironmentOptions::CheckOptions(std::vector<std::string>* errors,
errors->push_back("--heapsnapshot-near-heap-limit must not be negative");
}

if (!trace_require_module.empty() &&
trace_require_module != "all" &&
if (!trace_require_module.empty() && trace_require_module != "all" &&
trace_require_module != "no-node-modules") {
errors->push_back("invalid value for --trace-require-module");
}
Expand Down
8 changes: 4 additions & 4 deletions test/es-module/test-require-node-modules-warning.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spawnSyncAndAssert(
process.execPath,
[
'--trace-require-module=no-node-modules',
fixtures.path('es-modules', 'test_node_modules', 'require-esm.js')
fixtures.path('es-modules', 'test_node_modules', 'require-esm.js'),
],
{
trim: true,
Expand All @@ -31,7 +31,7 @@ spawnSyncAndAssert(
process.execPath,
[
'--trace-require-module=no-node-modules',
fixtures.path('es-modules', 'test_node_modules', 'require-require-esm.js')
fixtures.path('es-modules', 'test_node_modules', 'require-require-esm.js'),
],
{
trim: true,
Expand All @@ -46,7 +46,7 @@ spawnSyncAndAssert(
process.execPath,
[
'--trace-require-module=no-node-modules',
fixtures.path('es-modules', 'test_node_modules', 'import-require-esm.mjs')
fixtures.path('es-modules', 'test_node_modules', 'import-require-esm.mjs'),
],
{
trim: true,
Expand All @@ -61,7 +61,7 @@ spawnSyncAndAssert(
process.execPath,
[
'--trace-require-module=no-node-modules',
fixtures.path('es-modules', 'test_node_modules', 'import-import-require-esm.mjs')
fixtures.path('es-modules', 'test_node_modules', 'import-import-require-esm.mjs'),
],
{
trim: true,
Expand Down