Skip to content

lib: remove redundant global RegExps #56182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Dec 10, 2024
Merged

lib: remove redundant global RegExps #56182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: remove redundant global regexps
  • Loading branch information
@gurgunday
gurgunday committed Dec 8, 2024
commit f9a7c96edebb1ff1f244b93b21c2d1922fe2dd0f
2 changes: 1 addition & 1 deletion lib/internal/util/debuglog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ function formatTime(ms) {
}

function safeTraceLabel(label) {
return label.replace(/\\/g, '\\\\').replaceAll('"', '\\"');
return label.replaceAll('\\', '\\\\').replaceAll('"', '\\"');
}

/**
Expand Down
2 changes: 1 addition & 1 deletion lib/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ Url.prototype.format = function format() {
}
}

search = search.replace(/#/g, '%23');
search = search.replaceAll('#', '%23');

if (hash && hash.charCodeAt(0) !== CHAR_HASH)
hash = '#' + hash;
Expand Down