Skip to content

fs: improve error message for invalid flag #5590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 2 commits into from
Closed

fs: improve error message for invalid flag #5590

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a255da4
fs: improve error message for invalid flag
jasnell Mar 7, 2016
45ee049
test: expand test case for unknown file open flags
jasnell Mar 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fs: improve error message for invalid flag 
Flags on fs.open and others can be passed as strings or int.
Previously, if passing anything other than string or int,
the error message would only say that flags must be an int.
  • Loading branch information
@jasnell
jasnell committed Mar 9, 2016
commit a255da40d1de13c918223b4c814d79376ced0ccb
4 changes: 2 additions & 2 deletions lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,8 +536,8 @@ fs.readFileSync = function(path, options) {

// Used by binding.open and friends
function stringToFlags(flag) {
// Only mess with strings
if (typeof flag !== 'string') {
// Return early if it's a number
if (typeof flag === 'number') {
return flag;
}

Expand Down