Skip to content

fs: deprecate never throw behaviour in fs.existsSync #55753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 11 commits into from
Jan 10, 2025
Merged

fs: deprecate never throw behaviour in fs.existsSync #55753

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a7fd0e2
fs: deprecate never throw behaviour in fs.existsSync
Ceres6 Nov 6, 2024
247116e
fixup! fs: deprecate never throw behaviour in fs.existsSync
Ceres6 Nov 6, 2024
4c535cc
fixup! fixup! fs: deprecate never throw behaviour in fs.existsSync
Ceres6 Nov 6, 2024
be7ef4e
fs: deprecate never throw behaviour in fs.existsSync
Ceres6 Nov 6, 2024
f713685
fixup! fs: deprecate never throw behaviour in fs.existsSync
Ceres6 Nov 26, 2024
f32d873
fixup! fs: deprecate never throw behaviour in fs.existsSync
Ceres6 Nov 26, 2024
83687f4
Apply suggestions from code review
Ceres6 Nov 27, 2024
0484b00
fixup! fs: deprecate never throw behaviour in fs.existsSync
Ceres6 Nov 27, 2024
86bde37
fixup! fs: deprecate never throw behaviour in fs.existsSync
Ceres6 Jan 6, 2025
f70e0a2
Update doc/api/deprecations.md
Ceres6 Jan 6, 2025
6f5fda9
Merge branch 'main' into chore/deprecate-fs-existSync-never-throw
Ceres6 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fs: deprecate never throw behaviour in fs.existsSync
  • Loading branch information
@Ceres6
Ceres6 committed Jan 6, 2025
commit f7136853427a10a495eb8fd6f447bb92ff0679b6
2 changes: 1 addition & 1 deletion lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ function existsSync(path) {
try {
path = getValidatedPath(path);
} catch {
deprecate(() => {}, 'never throw on invalid arguments for fs.existsSync is deprecated', 'DEP0187');
deprecate(() => {}, 'Passing invalid argument types to fs.existsSync is deprecated', 'DEP0187');
Comment thread
Ceres6 marked this conversation as resolved.
Outdated
return false;
}

Expand Down