Skip to content

test: ignore unrelated events in FS watch tests #55605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 3 commits into from
Nov 6, 2024
Merged

test: ignore unrelated events in FS watch tests #55605

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38f4ed7
fs: ignore unrelated events in watch tests
Ceres6 Oct 30, 2024
43f81a6
Update test/parallel/test-fs-watch-recursive-add-file-to-new-folder.js
Ceres6 Oct 31, 2024
2a5af5f
fixup! Update test/parallel/test-fs-watch-recursive-add-file-to-new-f…
Ceres6 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! Update test/parallel/test-fs-watch-recursive-add-file-to-new-f… 
…older.js
  • Loading branch information
@Ceres6
Ceres6 committed Oct 31, 2024
commit 2a5af5ff99a9cde6fc7c5091027d96a11d9d784c
38 changes: 14 additions & 24 deletions test/parallel/test-fs-watch-recursive-add-file-to-new-folder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,30 +33,20 @@ const childrenAbsolutePath = path.join(filePath, childrenFile);
const childrenRelativePath = path.join(path.basename(filePath), childrenFile);
let watcherClosed = false;

function doWatch() {
const watcher = fs.watch(testDirectory, { recursive: true });
watcher.on('change', function(event, filename) {
if (filename === childrenRelativePath) {
assert.strictEqual(event, 'rename');
watcher.close();
watcherClosed = true;
}
});

// Do the write with a delay to ensure that the OS is ready to notify us.
setTimeout(() => {
fs.mkdirSync(filePath);
fs.writeFileSync(childrenAbsolutePath, 'world');
}, common.platformTimeout(200));
}

if (common.isMacOS) {
// On macOS delay watcher start to avoid leaking previous events.
// Refs: https://github.com/libuv/libuv/pull/4503
setTimeout(doWatch, common.platformTimeout(100));
} else {
doWatch();
}
const watcher = fs.watch(testDirectory, { recursive: true });
watcher.on('change', function(event, filename) {
if (filename === childrenRelativePath) {
assert.strictEqual(event, 'rename');
watcher.close();
watcherClosed = true;
}
});

// Do the write with a delay to ensure that the OS is ready to notify us.
setTimeout(() => {
fs.mkdirSync(filePath);
fs.writeFileSync(childrenAbsolutePath, 'world');
}, common.platformTimeout(200));
Comment thread
pmarchini marked this conversation as resolved.

process.once('exit', function() {
assert(watcherClosed, 'watcher Object was not closed');
Expand Down