Skip to content

src: use NewFromUtf8Literal in NODE_DEFINE_CONSTANT #55581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Oct 31, 2024
Merged

src: use NewFromUtf8Literal in NODE_DEFINE_CONSTANT #55581

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
943b125
src: use NewFromUtf8Literal in NODE_DEFINE_CONSTANT
ckerr Oct 28, 2024
49dafdd
chore: make linter happy
ckerr Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: use NewFromUtf8Literal in NODE_DEFINE_CONSTANT 
Small efficiency improvement over NewFromUtf8(): the literal's
length is known at compile time, so V8 doesn't have to call
strlen() or ToLocalChecked().
  • Loading branch information
@ckerr
ckerr committed Oct 28, 2024
commit 943b125ec074a8919d7bacdf75541296ac72b4d6
9 changes: 4 additions & 5 deletions src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,8 +1028,8 @@ NODE_DEPRECATED("Use v8::Date::ValueOf() directly",
v8::Isolate* isolate = target->GetIsolate(); \
v8::Local<v8::Context> context = isolate->GetCurrentContext(); \
v8::Local<v8::String> constant_name = \
v8::String::NewFromUtf8(isolate, #constant, \
v8::NewStringType::kInternalized).ToLocalChecked(); \
v8::String::NewFromUtf8Literal(isolate, #constant, \
v8::NewStringType::kInternalized); \
v8::Local<v8::Number> constant_value = \
v8::Number::New(isolate, static_cast<double>(constant)); \
v8::PropertyAttribute constant_attributes = \
Expand All @@ -1046,9 +1046,8 @@ NODE_DEPRECATED("Use v8::Date::ValueOf() directly",
v8::Isolate* isolate = target->GetIsolate(); \
v8::Local<v8::Context> context = isolate->GetCurrentContext(); \
v8::Local<v8::String> constant_name = \
v8::String::NewFromUtf8(isolate, #constant, \
v8::NewStringType::kInternalized) \
.ToLocalChecked(); \
v8::String::NewFromUtf8Literal(isolate, #constant, \
v8::NewStringType::kInternalized); \
v8::Local<v8::Number> constant_value = \
v8::Number::New(isolate, static_cast<double>(constant)); \
v8::PropertyAttribute constant_attributes = \
Expand Down