Skip to content

module: include module information in require(esm) warning #55397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Oct 22, 2024
Merged

module: include module information in require(esm) warning #55397

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c748d5e
module: include module information in require(esm) warning
joyeecheung Oct 15, 2024
5a78db6
fixup! module: include module information in require(esm) warning
joyeecheung Oct 18, 2024
30c2770
fixup! module: include module information in require(esm) warning
joyeecheung Oct 21, 2024
24d7d4e
fixup! module: include module information in require(esm) warning
joyeecheung Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! module: include module information in require(esm) warning 
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
  • Loading branch information
@joyeecheung @atlowChemi
joyeecheung and atlowChemi authored Oct 21, 2024
commit 30c2770ed9fd8418e2c6db0d15824fa651bb6b6b
2 changes: 1 addition & 1 deletion lib/internal/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ function slowCases(enc) {
}
}

function emitExperimentalWarning(feature, messageBefore) {
function emitExperimentalWarning(feature, messagePrefix) {
if (experimentalWarnings.has(feature)) return;
experimentalWarnings.add(feature);
let msg = `${feature} is an experimental feature and might change at any time`;
Expand Down